Skip to content

Add notification to pipeline #2325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 17, 2024
Merged

Add notification to pipeline #2325

merged 3 commits into from
Dec 17, 2024

Conversation

@rnc
Copy link
Collaborator

@rnc rnc commented Dec 12, 2024

No description provided.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 12, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@codecov
Copy link

codecov bot commented Dec 12, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 87.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 43.63%. Comparing base (be23096) to head (cfcbd23).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
...at/hacbs/container/notification/NotifyCommand.java 86.95% 3 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #2325      +/-   ##
============================================
+ Coverage     43.54%   43.63%   +0.08%     
- Complexity      802      808       +6     
============================================
  Files           280      282       +2     
  Lines         13345    13368      +23     
  Branches       1348     1348              
============================================
+ Hits           5811     5833      +22     
- Misses         6934     6936       +2     
+ Partials        600      599       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@openshift-ci openshift-ci bot added the lgtm label Dec 17, 2024
@rnc rnc marked this pull request as ready for review December 17, 2024 11:28
@openshift-ci openshift-ci bot requested a review from vibe13 December 17, 2024 11:29
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 17, 2024

@rnc: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/jvm-build-service-in-repo-e2e cfcbd23 link true /test jvm-build-service-in-repo-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@rnc rnc merged commit 908d8a5 into redhat-appstudio:main Dec 17, 2024
25 of 26 checks passed
ruhan1
ruhan1 reviewed Dec 18, 2024
View reviewed changes
deploy/pipeline/mw-pipeline-v0.1.yaml
- name: STATUS
value: $(tasks.status)
taskSpec:
params:
Copy link
Contributor

@ruhan1 ruhan1 Dec 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you miss param BULID_ID?

@rnc rnc deleted the BR3 branch December 19, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matejonnet matejonnet matejonnet approved these changes

@vibe13 vibe13 Awaiting requested review from vibe13

+1 more reviewer

@ruhan1 ruhan1 ruhan1 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@matejonnet matejonnet

Labels

lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rnc @matejonnet @ruhan1